Repository navigation
London | 26-ITP-Sep | Chandramani Gaire | Sprint 3 | Alarm clock app - #1556
Open
gaireprakash20-ops wants to merge 12 commits into
Open
gaireprakash20-ops wants to merge 12 commits into
gaireprakash20-ops wants to merge 12 commits into
Conversation
| String(minutes).padStart(2, "0") + ":" + String(seconds).padStart(2, "0") | ||
| ); | ||
| } | ||
| function setAlarm() { |
There was a problem hiding this comment.
What happens to the empty setAlarm declaration at the top now that this second declaration has been added?
To "like" or "dislike" this comment, please follow this link
| // DO NOT EDIT BELOW HERE | ||
|
|
||
| var audio = new Audio("alarmsound.mp3"); | ||
| let audio = new Audio("alarmsound.mp3"); |
There was a problem hiding this comment.
How does changing this declaration fit with the DO NOT EDIT BELOW HERE boundary immediately above it?
To "like" or "dislike" this comment, please follow this link
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1098
Changelist
I set the alarm function for alarm clock which can alarm as per the time setting.